georgexu99

#48795: fix(reland): allow disabling all NSMenuItems

Merged
Created: Nov 5, 2025, 6:43:36 PM
Merged: Nov 6, 2025, 9:02:05 PM
5 comments
Target: main

Description of Change

This PR relands #48731 , see that PR for details

Some submenu items do not have a representedObject that is a WeakPtrToElectronMenuModelAsNSObject. This causes an immediate crash when we try to call getFrom

Release Notes

Notes: Fixed an issue that menu items on macOS could not be disabled under all circumstances.

Backports

37-x-y
Merged
PR Number
#48827
Merged At
Nov 14, 2025, 9:58:48 AM
Released In
v37.10.1
Release Date
Nov 18, 2025, 10:04:25 AM
38-x-y
Merged
PR Number
#48829
Merged At
Nov 7, 2025, 3:37:01 AM
Released In
v38.7.0
Release Date
Nov 13, 2025, 8:31:35 PM
39-x-y
Merged
PR Number
#48830
Merged At
Nov 7, 2025, 3:36:49 AM
Released In
v39.1.2
Release Date
Nov 10, 2025, 2:06:59 PM
40-x-y
Merged
PR Number
#48828
Merged At
Nov 7, 2025, 4:23:12 AM
Released In
v40.0.0-alpha.5
Release Date
Nov 14, 2025, 2:22:11 PM

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron