georgexu99

#45000: fix: add patch to fix desktopCapturer.getSources not returning electron windows on Windows

Merged
Created: Dec 11, 2024, 5:32:30 PM
Merged: Dec 17, 2024, 5:20:44 PM
1 comments
Target: main

Description of Change

This patch is to fix issue #36037, where desktopCapturer.getSources does not return the electron window on Windows.

The first parameter added sets add_current_process_windows to true, allowing the desktopCapturer to enumerate electron windows. The second parameter is tentatively set at false to retain default behaviour.

Additional info about the second param, auto_show_delegated_source_list seems to be related to ongoing chromium work in the delegated source capturer

Tested by confirming the fiddle spawned app appears in this list of sources:
#45000

Release Notes

Notes: fix desktopCapturer.getSources not returning electron windows on Windows

Backports

No Backports Requested

This pull request doesn't have any backports requested or created for older release branches.

What are backports?

Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron