#45573: fix: osr crash on window close
Merged
Description of Change
Closes #45486.
Refs CL:5909989.
Fixes a crash that occurred in OSR after the above CL, which called into a RenderWidgetHostDelegate function without checking whether or not the delegate had been previously detached. Also pull in some other dtor fixes from CEF - see here
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed a crash that could occur in OSR on window close.
Backports
34-x-y
MergedPR Number
#45629Merged At
Feb 18, 2025, 3:19:49 PM
Released In
v34.3.0Release Date
Feb 26, 2025, 12:07:44 PM
35-x-y
MergedPR Number
#45630Merged At
Feb 17, 2025, 4:21:36 AM
Released In
v35.0.0-beta.7Release Date
Feb 17, 2025, 7:31:38 AM
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron