ckerr

#46283: fix: build failure when printing is disabled

Merged
Created: Mar 26, 2025, 12:20:55 AM
Merged: Mar 26, 2025, 5:04:39 AM
5 comments
Target: main

Description of Change

Fix 1d6cb34 FTBFS regression when building with printing disabled.

This breaks the Microsoft internal builds of Electron; so if possible, I'd like to get this landed before we kick off the weekly 33 and 34 releases.

CC @codebytere @electron/wg-releases

Checklist

Release Notes

Notes: Fixed build failure when building with printing disabled.

Backports

34-x-y
Merged
PR Number
#46286
Merged At
Mar 26, 2025, 10:46:59 AM
Released In
v34.4.0
Release Date
Mar 26, 2025, 12:03:07 PM
35-x-y
Merged
PR Number
#46285
Merged At
Mar 26, 2025, 7:48:46 AM
Released In
v35.1.1
Release Date
Mar 26, 2025, 12:03:07 PM
36-x-y
Merged
PR Number
#46284
Merged At
Mar 26, 2025, 7:48:49 AM
Released In
v36.0.0-alpha.6
Release Date
Mar 27, 2025, 9:31:53 AM

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron