#46283: fix: build failure when printing is disabled
Merged
Description of Change
Fix 1d6cb34 FTBFS regression when building with printing disabled.
This breaks the Microsoft internal builds of Electron; so if possible, I'd like to get this landed before we kick off the weekly 33 and 34 releases.
CC @codebytere @electron/wg-releases
Checklist
- PR description included and stakeholders cc'd
-
npm test
passes - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed build failure when building with printing disabled.
Backports
34-x-y
MergedPR Number
#46286Merged At
Mar 26, 2025, 10:46:59 AM
Released In
v34.4.0Release Date
Mar 26, 2025, 12:03:07 PM
35-x-y
MergedPR Number
#46285Merged At
Mar 26, 2025, 7:48:46 AM
Released In
v35.1.1Release Date
Mar 26, 2025, 12:03:07 PM
36-x-y
MergedPR Number
#46284Merged At
Mar 26, 2025, 7:48:49 AM
Released In
v36.0.0-alpha.6Release Date
Mar 27, 2025, 9:31:53 AM
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron