#46761: refactor: use std::map::try_emplace()
over std::map::insert()
Merged
Description of Change
Small cleanup in our use of maps: try_emplace()
has more efficient move semantics and its name is clearer about what happens when the same key is already present in the map. All other things being equal, we should use it instead of insert()
.
All human reviews welcomed! 😸 I'm also requesting a review from Copilot just to see what will happen; I've never used that before.
Checklist
- PR description included and stakeholders cc'd
-
npm test
passes - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none.
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron