ckerr

#46904: refactor: devirtualize NativeWindow methods

Merged
Created: May 2, 2025, 11:11:18 AM
Merged: May 5, 2025, 10:29:05 AM
3 comments
Target: main

Description of Change

NativeWindow has a handful of virtual methods that are never overridden. Let's devirtualize them to avoid the vtable overhead.

Checklist

Release Notes

Notes: none.

Backports

36-x-y
Merged
PR Number
#46930
Merged At
May 5, 2025, 12:59:31 PM
Released In
v36.2.0
Release Date
May 7, 2025, 12:02:14 PM
37-x-y
Merged
PR Number
#46931
Merged At
May 5, 2025, 2:39:51 PM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron