#46904: refactor: devirtualize NativeWindow methods
Merged
Description of Change
NativeWindow has a handful of virtual methods that are never overridden. Let's devirtualize them to avoid the vtable overhead.
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none.
Backports
36-x-y
MergedPR Number
#46930Merged At
May 5, 2025, 11:59:31 AM
Released In
v36.2.0Release Date
May 7, 2025, 11:02:14 AM
37-x-y
MergedPR Number
#46931Merged At
May 5, 2025, 1:39:51 PM
Released In
v37.0.0-alpha.4Release Date
May 12, 2025, 8:31:44 AM
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron