Electron Releases

Back to PR Lookup
GitHubView on GitHub
ckerr

#46919: refactor: remove some NativeWindow public API

Merged
ckerr
Created: May 3, 2025, 1:52:24 PM
Merged: May 5, 2025, 10:28:50 AM
4 comments
Target: main

Description of Change

Small refactor to make some incidentally-public API either protected or private

  • Remove NativeWindow::background_material(): it was only used in one place and that's in a const NativeWindow method, so remove the getter and just reference the field directly instead.
  • Remove NativeWindow::vibrancy(): same as above.
  • Make NativeWindow::set_has_frame() protected because it's only needed by subclasses.
  • Make NativeWindow::titlebar_overlay_height_ private. Clients should use the getter & setter.
  • Have NativeWindow unfriend api::BrowserView; this hasn't been needed since 2022

Checklist

Release Notes

Notes: none.

Backports

36-x-y
Merged
PR Number
#
Merged At
Released In
Not yet
Release Date
Not yet
37-x-y
Merged
PR Number
#46934
Merged At
May 6, 2025, 3:51:08 AM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron