#46937: fix: printing when no mediaSize specified
Merged
Description of Change
Closes #46921.
Ensures mediaSize defaults to A4 when no mediaSize is passed, fixing the following:
[83233:0505/195335.950737:ERROR:components/device_event_log/device_event_log_impl.cc:202] [19:53:35.950] Printer: print_view_manager_base.cc:384 Printer settings invalid for _127_0_0_1 (destination type kLocal): content size is empty; page size is empty; printable area is empty
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed an issue where webContents.print did not work as expected when mediaSize was not passed.
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron