Electron Releases

Back to PR Lookup
GitHubView on GitHub
ckerr

#46982: refactor: use gin_helper::Dictionary::ValueOrDefault()

Merged
ckerr
Created: May 7, 2025, 10:31:40 AM
Merged: May 8, 2025, 2:17:22 PM
3 comments
Target: main

Description of Change

A #46939 followup to use helper function Dictionary::ValueOrDefault() in a few more places.

These are all small cleanups to improve conciseness & readability. Here's an example:

-  int maxValue = 100;
-  int minValue = 0;
-  int value = 50;
-  settings.Get("minValue", &minValue);
-  settings.Get("maxValue", &maxValue);
-  settings.Get("value", &value);
-  item.slider.minValue = minValue;
-  item.slider.maxValue = maxValue;
-  item.slider.doubleValue = value;
+  item.slider.minValue = settings.ValueOrDefault("minValue", 0);
+  item.slider.maxValue = settings.ValueOrDefault("maxValue", 100);
+  item.slider.doubleValue = settings.ValueOrDefault("value", 50);

Checklist

Release Notes

Notes: none.

Backports

36-x-y
Merged
PR Number
#47015
Merged At
May 9, 2025, 2:36:55 AM
Released In
v36.2.1
Release Date
May 14, 2025, 11:03:54 AM
37-x-y
Merged
PR Number
#47014
Merged At
May 9, 2025, 2:36:47 AM
Released In
v37.0.0-alpha.4
Release Date
May 12, 2025, 8:31:44 AM

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron