#46982: refactor: use gin_helper::Dictionary::ValueOrDefault()
Merged
Description of Change
A #46939 followup to use helper function Dictionary::ValueOrDefault() in a few more places.
These are all small cleanups to improve conciseness & readability. Here's an example:
- int maxValue = 100;
- int minValue = 0;
- int value = 50;
- settings.Get("minValue", &minValue);
- settings.Get("maxValue", &maxValue);
- settings.Get("value", &value);
- item.slider.minValue = minValue;
- item.slider.maxValue = maxValue;
- item.slider.doubleValue = value;
+ item.slider.minValue = settings.ValueOrDefault("minValue", 0);
+ item.slider.maxValue = settings.ValueOrDefault("maxValue", 100);
+ item.slider.doubleValue = settings.ValueOrDefault("value", 50);Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none.
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron