codebytere

#47020: fix: restore previous Windows screenshotting

Merged
Created: May 9, 2025, 3:34:37 AM
Merged: May 9, 2025, 10:38:27 AM
6 comments
Target: main

Description of Change

Fixes #45990

We previously made a change in #45868 to fix content protection being lost on hide and re-show. However, this cause a breaking change where protected windows were made opaque black instead of being hidden as before. This overrides relevant methods in ElectronDesktopWindowTreeHostWin to restore the previous behavior. without regressing the original issue.

Checklist

Release Notes

Notes: Restored previous window-hiding behavior of win.setContentProtected() on Windows.

Backports

35-x-y
Merged
PR Number
#47034
Merged At
May 9, 2025, 6:47:37 PM
Released In
Not yet
Release Date
Not yet
36-x-y
Merged
PR Number
#47032
Merged At
May 9, 2025, 1:10:19 PM
Released In
Not yet
Release Date
Not yet
37-x-y
Merged
PR Number
#47033
Merged At
May 9, 2025, 1:10:44 PM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron