#47020: fix: restore previous Windows screenshotting
Merged
Description of Change
Fixes #45990
We previously made a change in #45868 to fix content protection being lost on hide and re-show. However, this cause a breaking change where protected windows were made opaque black instead of being hidden as before. This overrides relevant methods in ElectronDesktopWindowTreeHostWin to restore the previous behavior. without regressing the original issue.
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - tests are changed or added
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Restored previous window-hiding behavior of win.setContentProtected() on Windows.
Backports
35-x-y
MergedPR Number
#47034Merged At
May 9, 2025, 5:47:37 PM
Released In
v35.4.0Release Date
May 14, 2025, 11:02:18 AM
36-x-y
MergedPR Number
#47032Merged At
May 9, 2025, 12:10:19 PM
Released In
v36.2.1Release Date
May 14, 2025, 11:03:54 AM
37-x-y
MergedPR Number
#47033Merged At
May 9, 2025, 12:10:44 PM
Released In
v37.0.0-alpha.4Release Date
May 12, 2025, 8:31:44 AM
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron