#47148: refactor: add NativeWindow::IsActive()
this was already present on macOS; use in NativeWindowViews too
Description of Change
Part 4 in a short series of PRs to reduce public use of NativeWindow::widget()
so that it can be made into a protected method. See Part 1 for discussion of why I want to do that.
This PR adds NativeWindow::IsActive()
on all platforms, when previously it existed only on macOS builds. WebContents::ReadyToCommitNavigation()
can use this method instead of calling NativeWindow::widget()->IsActive()
on Windows and Linux.
Checklist
- PR description included and stakeholders cc'd
-
npm test
passes - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none.
Backports
No Backports Requested
This pull request doesn't have any backports requested or created for older release branches.
What are backports?
Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.
Semver Impact
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron