ckerr

#47156: refactor: make NativeWindow::has_client_frame_ const

Merged
Created: May 19, 2025, 5:03:47 PM
Merged: May 20, 2025, 5:14:28 PM
4 comments
Target: main

Description of Change

Part of a general refactoring of NativeWindow to lock down its API, e.g. changing members from public to non-public and/or making them const.

This PR makes NativeWindow::has_client_frame_ a const field since it never changes.

Checklist

Release Notes

Notes: none.

Backports

35-x-y
Merged
PR Number
#47178
Merged At
May 20, 2025, 7:39:16 PM
Released In
Not yet
Release Date
Not yet
36-x-y
Merged
PR Number
#47179
Merged At
May 20, 2025, 9:02:35 PM
Released In
v36.3.0
Release Date
May 22, 2025, 8:18:58 AM
37-x-y
Merged
PR Number
#47180
Merged At
May 21, 2025, 4:44:36 AM
Released In
v37.0.0-alpha.6
Release Date
May 22, 2025, 10:18:26 AM

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron