jkleinsc

#47194: build: fix depot tool pathing on Windows

Merged
Created: May 21, 2025, 12:05:50 PM
Merged: May 21, 2025, 6:05:51 PM
6 comments
Target: main

Description of Change

  • Followup to #47160. Unfortunately that PR did not fix the issue as it turns out the issue is caused by depot_tools being preinstalled on the widows runner image. This PR fixes the underlying issue by properly setting the path to the depot_tools installed as part of the build which will then resolve this error:
python3_bin_reldir.txt not found. need to initialize depot_tools by
running gclient, update_depot_tools or ensure_bootstrap.

Verified by building ffmpeg for a testing build here: https://github.com/electron/electron/actions/runs/15171656549/job/42663073571?pr=47194#step:23:43892

Once this PR makes it way through all supported branches, we can remove depot_tools from the windows runner image by reapplying electron/infra#120

Checklist

Release Notes

Notes: none

Backports

34-x-y
Merged
PR Number
#
Merged At
Released In
Not yet
Release Date
Not yet
35-x-y
Merged
PR Number
#47227
Merged At
May 22, 2025, 1:57:24 PM
Released In
v35.5.0
Release Date
May 28, 2025, 11:03:13 AM
36-x-y
Merged
PR Number
#47204
Merged At
May 22, 2025, 7:39:50 AM
Released In
v36.3.0
Release Date
May 22, 2025, 8:18:58 AM
37-x-y
Merged
PR Number
#47205
Merged At
May 22, 2025, 10:16:37 AM
Released In
v37.0.0-alpha.6
Release Date
May 22, 2025, 10:18:26 AM

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron