#47243: chore: debug crash on DevTools SetOwnerWindow
Merged
Description of Change
Debug #47187 by:
- Adding SEQUENCE_CHECKER for
InspectableWebContents
andDCHECK_CALLED_ON_VALID_SEQUENCE
toInspectableWebContents::LoadCompleted
- Adding
DCHECK(!owner_window_.WasInvalidated())
to ensure window of the webContents holding the devtools is valid - Adding
DCHECK_EQ(handle->owner_window(), nullptr)
to ensure the devtools does not have a owner window
Checklist
- PR description included and stakeholders cc'd
-
npm test
passes - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none
Backports
35-x-y
MergedPR Number
#47261Merged At
May 27, 2025, 7:24:10 AM
Released In
v35.5.0Release Date
May 28, 2025, 11:03:13 AM
36-x-y
MergedPR Number
#47262Merged At
May 26, 2025, 10:33:02 PM
Released In
v36.3.2Release Date
May 28, 2025, 11:03:18 AM
37-x-y
MergedPR Number
#47263Merged At
May 26, 2025, 10:32:45 PM
Released In
v37.0.0-beta.1Release Date
May 27, 2025, 1:48:46 PM
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron