codebytere

#47243: chore: debug crash on DevTools SetOwnerWindow

Merged
Created: May 23, 2025, 3:11:09 AM
Merged: May 26, 2025, 2:45:43 AM
4 comments
Target: main

Description of Change

Debug #47187 by:

  1. Adding SEQUENCE_CHECKER for InspectableWebContents and DCHECK_CALLED_ON_VALID_SEQUENCE to InspectableWebContents::LoadCompleted
  2. Adding DCHECK(!owner_window_.WasInvalidated()) to ensure window of the webContents holding the devtools is valid
  3. Adding DCHECK_EQ(handle->owner_window(), nullptr) to ensure the devtools does not have a owner window

Checklist

Release Notes

Notes: none

Backports

35-x-y
Merged
PR Number
#47261
Merged At
May 27, 2025, 7:24:10 AM
Released In
v35.5.0
Release Date
May 28, 2025, 11:03:13 AM
36-x-y
Merged
PR Number
#47262
Merged At
May 26, 2025, 10:33:02 PM
Released In
v36.3.2
Release Date
May 28, 2025, 11:03:18 AM
37-x-y
Merged
PR Number
#47263
Merged At
May 26, 2025, 10:32:45 PM
Released In
v37.0.0-beta.1
Release Date
May 27, 2025, 1:48:46 PM

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron