#47428: refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>
Merged
Description of Change
A small side refactor to prefer return values to output parameters in ShowSaveDialogSync().
- bool ShowSaveDialogSync(const DialogSettings& settings, base::FilePath* path);
+ std::optional<base::FilePath> ShowSaveDialogSync(const DialogSettings& settings);Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none
Backports
36-x-y
MergedPR Number
#47452Merged At
Jun 13, 2025, 3:03:06 AM
Released In
v36.5.0Release Date
Jun 17, 2025, 3:38:08 PM
37-x-y
MergedPR Number
#47453Merged At
Jun 13, 2025, 3:03:03 AM
Released In
v37.0.0-beta.6Release Date
Jun 16, 2025, 8:31:33 AM
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron