#47445: refactor: move gin::Converter<PreloadScript> impl to a .cc file
Merged
Description of Change
Small refactor to just move the implementation of gin::Converter<PreloadScript> from a header file into a cc file. Since preload_script.h is indirectly included by a lot of our source files, this change helps reduce incidental includes.
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none.
Backports
36-x-y
MergedPR Number
#47467Merged At
Jun 16, 2025, 9:55:01 AM
Released In
v36.5.0Release Date
Jun 17, 2025, 3:38:08 PM
37-x-y
MergedPR Number
#47466Merged At
Jun 16, 2025, 10:10:02 AM
Released In
v37.0.0-beta.7Release Date
Jun 16, 2025, 11:23:17 PM
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron