#47482: fix: revert moving IsClosed() and IsClosable() into NativeWindow::Close()
Merged
Description of Change
We're seeing a group of tests that are now failing on Electron 37 between alpha.2 and alpha.3; while debugging, it looks like the app is not closing properly between tests. This PR attempts to revert IsClose() logic refactoring that landed around the time of the regression
This reverts commit 3faddd5.
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - tests are changed or added
- relevant API documentation, tutorials, and examples are updated and follow the documentation style guide
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed an issue on application close on Windows, where not all processes are quit on close.
Backports
37-x-y
MergedPR Number
#47485Merged At
Jun 16, 2025, 11:20:54 PM
Released In
v37.0.0-beta.7Release Date
Jun 16, 2025, 11:23:17 PM
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron