ckerr

#47588: refactor: avoid copies of large objects in range based for loops

Merged
Created: Jun 27, 2025, 10:34:22 AM
Merged: Jun 29, 2025, 2:32:26 PM
4 comments
Target: main

Description of Change

Copy upstream RecursiveDumpAXPlatformNodeAsString() fix to avoid temporary copies of std::strings in range-based for loops.

Also apply the same fix to Browser::ShowAboutPanel(), where we also had this wart.

Checklist

Release Notes

Notes: none.

Backports

36-x-y
Merged
PR Number
#47604
Merged At
Jun 30, 2025, 3:59:59 AM
Released In
v36.7.0
Release Date
Jul 2, 2025, 11:02:58 AM
37-x-y
Merged
PR Number
#47605
Merged At
Jun 30, 2025, 3:28:55 AM
Released In
v37.2.0
Release Date
Jul 2, 2025, 11:02:00 AM
38-x-y
Merged
PR Number
#47606
Merged At
Jun 30, 2025, 3:28:53 AM
Released In
v38.0.0-alpha.3
Release Date
Jun 30, 2025, 8:31:18 AM

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron