ckerr

#47593: perf: avoid copying a vector when calling ConvertToWeakPtrVector()

Merged
Created: Jun 27, 2025, 3:49:15 PM
Merged: Jun 29, 2025, 2:32:03 PM
4 comments
Target: main

Description of Change

Have ConvertToWeakPtrVector() take a const vector& instead of a vector to avoid an unnecessary vector copy.

Checklist

Release Notes

Notes: none.

Backports

36-x-y
Merged
PR Number
#47602
Merged At
Jun 30, 2025, 3:29:16 AM
Released In
v36.7.0
Release Date
Jul 2, 2025, 11:02:58 AM
37-x-y
Merged
PR Number
#47601
Merged At
Jun 30, 2025, 3:29:14 AM
Released In
v37.2.0
Release Date
Jul 2, 2025, 11:02:00 AM
38-x-y
Merged
PR Number
#47603
Merged At
Jun 30, 2025, 3:59:53 AM
Released In
v38.0.0-alpha.3
Release Date
Jun 30, 2025, 8:31:18 AM

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron