codebytere

#47629: fix: accent color should reflect system settings without restart

Merged
Created: Jul 1, 2025, 8:17:46 AM
Merged: Jul 3, 2025, 11:13:39 AM
4 comments
Target: main

Description of Change

Closes #47626.
Refs #47285 (comment).

Fixes an issue where a window's accent color didn't reflect system settings without restart.

After this PR:

  • System Accent Disabled and accentColor: undefined => ❌ Frame does NOT have accent color
  • System Accent Disabled and accentColor: true => ✅ Frame has accent color
  • System Accent Disabled and accentColor: #rrggbb => ✅ Frame has accent color
  • System Accent Disabled and accentColor: false => ❌ Frame does NOT have accent color
  • System Accent Enabled and accentColor: undefined => ✅ Frame has accent color
  • System Accent Enabled and accentColor: true => ✅ Frame has accent color
  • System Accent Enabled and accentColor: #rrggbb => ✅ Frame has accent color
  • System Accent Enabled and accentColor: false => ❌ Frame does NOT have accent color

cc @bpasero

Checklist

Release Notes

Notes: Fixed an issue where the window required restart in order to recognize system accent color setting change.

Backports

36-x-y
Merged
PR Number
#47657
Merged At
Jul 4, 2025, 3:57:23 AM
Released In
Not yet
Release Date
Not yet
37-x-y
Merged
PR Number
#47656
Merged At
Jul 3, 2025, 3:19:26 PM
Released In
Not yet
Release Date
Not yet
38-x-y
Merged
PR Number
#47658
Merged At
Jul 3, 2025, 3:19:29 PM
Released In
v38.0.0-alpha.4
Release Date
Jul 7, 2025, 8:32:17 AM

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron