#47641: fix: crash on source capture with empty thumbnail size
Merged
Description of Change
Refs CL:5783826
Closes #47591
Fixes a crash when calling desktopCapturer.getSources with an empty thumbnail size.
DesktopMediaListBase now calls Refresh(false) after dispatching DesktopMediaListObserver::OnDelegatedSourceListSelection, so it's important not to call DesktopCapturer::HandleSuccess (which deallocates the DesktopMediaList) synchronously from OnDelegatedSourceListSelection.
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed a crash when calling desktopCapturer.getSources with an empty thumbnail size.
Backports
36-x-y
MergedPR Number
#47651Merged At
Jul 3, 2025, 12:19:13 PM
Released In
v36.7.1Release Date
Jul 11, 2025, 4:00:23 PM
37-x-y
MergedPR Number
#47653Merged At
Jul 3, 2025, 12:19:23 PM
Released In
v37.2.1Release Date
Jul 9, 2025, 11:02:22 AM
38-x-y
MergedPR Number
#47652Merged At
Jul 3, 2025, 3:19:43 PM
Released In
v38.0.0-alpha.4Release Date
Jul 7, 2025, 8:32:17 AM
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron