#47751: fix: handle missing NativeWindowMac in ElectronNSWindow
Merged
Description of Change
Fixes an issue where certain operations performed in a window close callback could trigger a crash. After #44628 it's possible for ElectronNSWindow to outlive shell_ and thus we should check that it's not nullptr prior to use.
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed an issue where certain operations performed in a window close callback could trigger a crash.
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron