#47759: fix: corner smoothing feature gate crash
Merged
Description of Change
There was a crash in third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
from parsing the -electron-corner-smoothing
CSS property when the property was added to a stylesheet with no associated document. To resolve this, I changed the feature gating to use Blink's built-in runtime feature gating instead. As a result, I was able to cut out a majority of the patch that was just for plumbing the web preference. There is an insignificant API change for how the feature is disabled.
Checklist
- PR description included and stakeholders cc'd
-
npm test
passes - tests are changed or added
- relevant API documentation, tutorials, and examples are updated and follow the documentation style guide
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed a crash when adding the -electron-corner-smoothing
CSS rule to a stylesheet with no associated document.
Backports
37-x-y
MergedPR Number
#47792Merged At
Jul 16, 2025, 2:03:27 PM
Released In
v37.2.3Release Date
Jul 16, 2025, 2:05:30 PM
38-x-y
MergedPR Number
#47785Merged At
Jul 16, 2025, 2:15:54 PM
Released In
v38.0.0-alpha.7Release Date
Jul 17, 2025, 8:32:12 AM
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron