deepak1556

#47958: chore: move gin::DeprecatedWrappable to gin_helper

Merged
Created: Aug 4, 2025, 4:36:27 AM
Merged: Aug 4, 2025, 9:28:01 AM
5 comments
Target: main

Description of Change

This is in preparation for migrating to gin::Wrappable based on cppgc #47922 The upstream class will be deleted soon via roller PR #47929 but the cppgc migration should happen outside the roll, this change retains the current functionality by copying the implementation into //electron/shell/common/gin_helper. The class can be deleted once the cppgc migration is complete.

CL removing gin::DeprecatedWrappable https://chromium-review.googlesource.com/c/chromium/src/+/6799157

There is no functionality change in this PR.

Release Notes

Notes: none

Backports

38-x-y
Merged
PR Number
#47996
Merged At
Aug 8, 2025, 11:00:45 PM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron