#47967: chore: Remove redundant IS_WIN check inside electron_main_win.cc
Merged
Description of Change
This code snipped was moved from shell/browser/electron_browser_main_parts.cc to shell/app/electron_main_win.cc in #35529
When it lived in electron_browser_main_parts.cc the IS_WIN check made sense because that file used on all platforms. However, electron_main_win.cc is Windows specific, so the compiler directive is unnecessary.
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none
Backports
No Backports Requested
This pull request doesn't have any backports requested or created for older release branches.
What are backports?
Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron