codebytere

#48181: fix: showMessageDialog should center dialog to parent

Merged
Created: Aug 27, 2025, 3:53:46 AM
Merged: Aug 29, 2025, 2:56:51 AM
4 comments
Target: main

Description of Change

Closes #23001.

Fixes an issue where dialog.showMessageDialog showed a window incorrectly centered to monitor instead of parent window when passed.

Before

Screenshot 2025-08-27 at 10 50 56 AM

After

Screenshot 2025-08-27 at 10 53 11 AM

Checklist

Release Notes

Notes: Fixed an issue where dialog.showMessageDialog showed a window incorrectly centered to monitor instead of parent window when passed.

Backports

36-x-y
In-flight
PR Number
#48214
Waiting to be merged
37-x-y
In-flight
PR Number
#48213
Waiting to be merged
38-x-y
In-flight
PR Number
#48215
Waiting to be merged

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron