#48199: fix: ensure dragging works again after emitting contextmenu event
Merged
Description of Change
Closes #48179.
Fixes an issue where dragging sometimes didn't work after the contextmenu event was emitted. This happened because WM_RBUTTONUP can be racy with the mousehandler, so the call to electron::api::WebContents::SetDisableDraggableRegions(false) didn't always happen as expected. Fix this by consolidating logic into ElectronDesktopWindowTreeHostWin::HandleMouseEvent.
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed an issue where dragging sometimes didn't work after the contextmenu event was emitted.
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron