Electron Releases

Back to PR Lookup
GitHubView on GitHub
VerteDinde

#48335: chore: cherry-pick ec6c18478382 from v8

Merged
VerteDinde
Created: Sep 16, 2025, 6:06:49 PM
Merged: Sep 16, 2025, 9:08:15 PM
5 comments
Target: main

[compiler] Don't assume that upper 32-bit of Int32MulOvfCheck are 0

Because Arm64 doesn't have a flag-setting 32-bit multiplication,
which means that instead with use a 64-bit multiplication, and compare
result.X() and result.W() to check if an overflow happened. But this
leads to the upper 32-bit not being zeroed.

Fixed: 445380761
Change-Id: I31287faf37dc615695047021324e9d1d802cbec2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6954290
Auto-Submit: Darius Mercadier dmercadier@chromium.org
Commit-Queue: Leszek Swirski leszeks@chromium.org
Reviewed-by: Leszek Swirski leszeks@chromium.org
Cr-Commit-Position: refs/heads/main@{#102530}

Notes: Backported fix for 445380761.

Backports

36-x-y
Merged
PR Number
#48339
Merged At
Sep 16, 2025, 9:52:23 PM
Released In
v36.9.1
Release Date
Sep 16, 2025, 10:34:05 PM
37-x-y
Merged
PR Number
#48338
Merged At
Sep 16, 2025, 9:36:52 PM
Released In
v37.5.1
Release Date
Sep 16, 2025, 9:38:35 PM
38-x-y
Merged
PR Number
#48337
Merged At
Sep 17, 2025, 1:24:50 AM
Released In
v38.1.2
Release Date
Sep 17, 2025, 1:26:11 AM
39-x-y
Merged
PR Number
#48336
Merged At
Sep 16, 2025, 9:09:16 PM
Released In
v39.0.0-alpha.4
Release Date
Sep 18, 2025, 8:31:42 AM

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron