#48456: perf: avoid a little extra work in InvokeIpcCallback()
Merged
Description of Change
Avoid a little extra work in InvokeIpcCallback()
:
- Allocate the
node::CallbackScope
on the stack instead of the heap by usingstd::optional
instead ofstd::unique_ptr
. - Skip a redundant call to
node::Environment::GetCurrent()
by passingenv
to the callback scope's constructor
Checklist
- PR description included and stakeholders cc'd
-
npm test
passes - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none.
Backports
39-x-y
MergedPR Number
#48466Merged At
Oct 6, 2025, 12:10:08 PM
Released In
v39.0.0-beta.1Release Date
Oct 6, 2025, 4:34:18 PM
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron