jkleinsc

#48470: build: fixup chromedriver and mksnapshot

Merged
Created: Oct 6, 2025, 9:16:43 AM
Merged: Oct 6, 2025, 10:22:55 PM
6 comments
Target: main

Description of Change

  1. Build failures are silently failing/not marking the build as failing. This issue is addressed via electron/build-tools#759
  2. The build failure seems to be happening because we run 2 targets back to back which seems to cause file contention on siso builds on Windows sometimes. In both cases instead of calling e build with the build target and then calling e build with the zip target, we can directly call e build with the zip target which should fix this contention issue.
  3. chromedriver and mksnapshot are not used in our tests, so we are currently unnecessarily unzipping these zip files in our tests, so this PR removes unzipping those files.

Checklist

Release Notes

Notes: none

Backports

36-x-y
Pending
Waiting for a manual backport
37-x-y
Pending
Waiting for a manual backport
38-x-y
In-flight
PR Number
#48481
Waiting to be merged
39-x-y
Merged
PR Number
#48479
Merged At
Oct 7, 2025, 4:08:17 AM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron