#48470: build: fixup chromedriver and mksnapshot
Merged
Description of Change
-
After the migration to siso via #47534, on occasion on Windows mksnapshot or chromedriver fails to build which then causes errors while testing, eg https://github.com/electron/electron/actions/runs/18198927807/job/51842938994?pr=48439.
-
It turns out there are several issues at hand here:
- Build failures are silently failing/not marking the build as failing. This issue is addressed via electron/build-tools#759
- The build failure seems to be happening because we run 2 targets back to back which seems to cause file contention on siso builds on Windows sometimes. In both cases instead of calling e build with the build target and then calling e build with the zip target, we can directly call
e build
with the zip target which should fix this contention issue. - chromedriver and mksnapshot are not used in our tests, so we are currently unnecessarily unzipping these zip files in our tests, so this PR removes unzipping those files.
Checklist
- PR description included and stakeholders cc'd
-
npm test
passes - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron