#48634: fix: logical bug in install.js env var handling
Merged
Description of Change
If either NPM_CONFIG_ELECTRON_USE_REMOTE_CHECKSUMS or ELECTRON_USE_REMOTE_CHECKSUMS are set as environment variables, then force Electron to verify with remote checksums instead of embedded ones.
Fixes #48594.
Thanks to @KinshukSS2 for reporting this and suggesting a solution.
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed an error when checking environmental variables when using remote checksums when installing Electron via npm.
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron