KinshukSS2

#48639: fix: use correct signal variable in nan-spec-runner install check

Merged
Created: Oct 23, 2025, 12:00:03 AM
Merged: Oct 28, 2025, 10:18:47 AM
8 comments
Target: main

The install process spawn was not capturing its own signal variable, causing the error check to incorrectly reference the build signal instead. This could lead to:

  • Install termination by signal going undetected
  • False positive errors when build was killed but install succeeded

This commit ensures the install signal is properly captured and checked, matching the pattern used for the build process.

Description of Change

In script/nan-spec-runner.js, the yarn install spawn (line 115) only destructured status but the error check (line 122) referenced signal from the build process instead of the install process signal. This fix captures the install signal and uses it correctly in the error check.

FIxes #48636

Before:

const { status: installStatus } = cp.spawnSync(...)
if (installStatus !== 0 || signal != null) { // 'signal' is from build ,not install

After:

const { status: installStatus, signal: installSignal } = cp.spawnSync(...)
if (installStatus !== 0 || installSignal != null) {

Checklist

Release Notes

Notes: Fixed incorrect signal variable reference in nan-spec-runner that could cause install failures to go undetected.

Backports

38-x-y
In-flight
PR Number
#48708
Waiting to be merged
39-x-y
Merged
PR Number
#48709
Merged At
Oct 28, 2025, 1:58:32 PM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron