#48640: fix: crash on empty dialog extensions array on Windows
Merged
Description of Change
Closes #48611
Fixes a crash caused by the following:
out_of_range was thrown in -fno-exceptions mode with message "basic_string"
Due to a stricter -fno-exceptions introduced in Chromium via v33.2.0...v33.2.1.
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed a potential crash in dialog.showOpenDialog on Windows with an empty extension filter array.
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron