ckerr

#48885: refactor: use gin_helper's gin::Wrappable-to-v8::Local converter

Merged
Created: Nov 10, 2025, 5:28:29 PM
Merged: Nov 11, 2025, 12:33:25 AM
1 comments
Target: main

Description of Change

Remove some unnecessary code duplication in api::Session.

Now that api::Session and api::NetLog are cpp-managed gin::Wrappable subclasses, we can use gin_helper's gin::Wrappable-to-v8::Local converter instead of reinventing the wheel each time.

Partially related to #47922, but this is more of a cleanup task.

CC @deepak1556 @codebytere

Checklist

Release Notes

Notes: none.

Backports

No Backports Requested

This pull request doesn't have any backports requested or created for older release branches.

What are backports?

Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron