Electron Releases

Back to PR Lookup
GitHubView on GitHub
This is a backport PR for branch 39-x-y
trop[bot]

#49045: fix: only call popup closecallback for top-level menu

Open
trop[bot]
Created: Nov 21, 2025, 9:38:03 AM
0 comments
Target: 39-x-y

Backport of #49017

See that PR for details.

Notes: Fixed an issue where the close callback param for menu.popup would fire when any arbitrary submenu of the given menu closed, and not the menu itself.

Backport Information

Backported from

#49017: fix: only call popup closecallback for top-level menu
Original PR Author
codebytere
Original PR Status
Merged
Original PR Merged At
Nov 21, 2025, 9:37:47 AM
Original PR Link
GitHubView on GitHub

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron