#49318: refactor: have GetXdgAppId() return a std::optional<std::string>
Merged
Description of Change
A minor GetXdgAppId() cleanup that came about while doing background reading for reviewing #49270.
- The main goal is to improve the code comments and link to 3rd party documentation, e.g. to the relevant XDG specs and GNOME docs.
- Change the return type of
GetXdgAppId()tostd::optional<std;:string>. This is more consistent with the sibling functionGetDesktopName()and slightly simplifies the code in 49270, e.g. letting callers use something likeGetXdgAppId().value_or(fallback_value); - Simplify our
app.setDesktopName()calls
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none.
Backports
No Backports Requested
This pull request doesn't have any backports requested or created for older release branches.
What are backports?
Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron