#49348: fix: provide explicit cookie encryption provider for cookie encryption
Merged
Description of Change
This PR modifies our existing cookie encryption logic to match an upstream change here, which now requires a cookie encryption provider for the network service to use if cookie encryption is enabled: Reland "Port net::CookieCryptoDelegate to os_crypt async" | https://chromium-review.googlesource.com/c/chromium/src/+/6996667
This bug is also present in 40-x-y; we should try to land this fix before the 40.0.0 stable cut next week, as missing it could potentially break applications using cookie encryption.
Checklist
- PR description included and stakeholders cc'd
-
npm testpasses - tests are changed or added
- relevant API documentation, tutorials, and examples are updated and follow the documentation style guide
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed an issue where no cookie encryption provider was passed into the network service when cookie encryption was enabled.
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron