dsanders11

#49630: ci: handle PRs with no checks in rerun apply patches

Merged
Created: Feb 3, 2026, 1:28:35 AM
Merged: Feb 4, 2026, 9:13:28 AM
4 comments
Target: main

Description of Change

There's an edge case that I wasn't aware of before, where gh pr checks exits with a non-zero exit code if there are "no checks reported" for a PR. This seems to be the case for some old PRs that are in merge conflict state.

This PR refactors the workflow to use gh pr view instead, which has all the same information we need, in slightly different named fields. Since gh pr view is just for viewing a PR, it won't fail on this edge case, statusCheckRollup will just be an empty array.

Checklist

  • PR description included

Release Notes

Notes: none

Backports

39-x-y
Merged
PR Number
#49663
Merged At
Feb 4, 2026, 11:45:43 AM
Released In
Not yet
Release Date
Not yet
40-x-y
Merged
PR Number
#49662
Merged At
Feb 4, 2026, 11:46:02 AM
Released In
Not yet
Release Date
Not yet
41-x-y
Merged
PR Number
#49664
Merged At
Feb 4, 2026, 11:46:38 AM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron