#49654: refactor: don't log error just for unsigned code
Merged
Description of Change
Should resolve #49652.
We don't really need to log an error when the code we're checking in ProcessSignatureIsSameWithCurrentApp is unsigned. It's not a system failure, we can just conclude that the signatures don't match (since we already return early if we ourselves aren't signed, the only way to reach that line of code is if we're signed; and no unsigned process (the thing were checking) has any way of matching the signature of our signed code).
Checklist
- PR description included
- I have built and tested this PR (it compiles and builds, but I don't have an Intel Mac with which to reproduce the original issue (though the code should be self-explanatory)).
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron