codebytere

#50001: build: authenticate curl requests to googlesource in lint workflow

Merged
Created: Mar 2, 2026, 5:36:07 AM
Merged: Mar 2, 2026, 10:29:50 AM
6 comments
Target: main

Description of Change

Speculative fix for lint failures!

The "Download GN Binary" and "Download clang-format Binary" steps fetch files from chromium.googlesource.com without passing authentication cookies. When googlesource rate-limits or returns a transient error (502), the HTML error page is piped into base64 -d, causing base64: invalid input.

The set-chromium-cookie action already configures ~/.gitcookies in a prior step. Pass -b ~/.gitcookies to both curl calls so they authenticate, matching what the cookie verification step itself does.

Checklist

Release Notes

Notes: none

Backports

38-x-y
Merged
PR Number
#50025
Merged At
Mar 2, 2026, 5:40:33 PM
Released In
Not yet
Release Date
Not yet
39-x-y
Merged
PR Number
#50026
Merged At
Mar 2, 2026, 5:39:45 PM
Released In
v39.8.0
Release Date
Mar 3, 2026, 10:03:24 AM
40-x-y
Merged
PR Number
#50027
Merged At
Mar 2, 2026, 5:38:50 PM
Released In
v40.7.0
Release Date
Mar 3, 2026, 10:03:33 AM
41-x-y
Merged
PR Number
#50028
Merged At
Mar 2, 2026, 5:38:07 PM
Released In
Not yet
Release Date
Not yet

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron