dsanders11

#50311: chore: add missing timers-shim.ts to filenames.auto.gni

Merged
Created: Mar 17, 2026, 12:49:39 AM
Merged: Mar 17, 2026, 3:46:15 AM
1 comments
Target: main

Description of Change

Follow-up to #50203. This gets automatically added if script/gen-filenames.ts gets run, but since it was missed in the previous this is going to try to sneak into another PR the next time that script gets run.

As a follow-up task here, we should really be detecting this issue in CI. Currently the only time script/gen-filenames.ts gets run is as a precommit hook, which can get missed for various reasons. We should add a step in CI that runs this script and its siblings (script/gen-hunspell-filenames.js and script/gen-libc++-filenames.js) and fail if there's local changes after running them.

Checklist

  • PR description included

Release Notes

Notes: none

Backports

No Backports Requested

This pull request doesn't have any backports requested or created for older release branches.

What are backports?

Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron