MarshallOfSound

#51303: build: rebase siso patches onto siso 7bcc56206d23

Merged
Created: Apr 23, 2026, 6:57:39 PM
Merged: Apr 23, 2026, 9:15:12 PM
1 comments
Target: main

The Chromium 149.0.7798.0 roll (#50814) bumped the pinned siso revision to 7bcc56206d234b3024df08ffd4ee6d40eea32623, and upstream added a path/filepath import to siso/toolsupport/ninjautil/file_parser.go. That broke the import-block context for the 0002 ERROR_INVALID_PARAMETER retry patch, so git am --3way could no longer build a fake ancestor and the build-siso-windows job has been failing at the Apply in-tree siso patches step on main.

This re-exports both .github/siso-patches/ patches against the new siso SHA. No functional change to the patched code — only line offsets, index hashes and the import-hunk context move.

Verified locally by replicating the CI step end-to-end: fresh --depth=1 clone of chromium.googlesource.com/build at the pinned SHA, git am --3way .github/siso-patches/*.patch, go vet ./toolsupport/ninjautil/..., and CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build all succeed.

Notes: none

Backports

No Backports Requested

This pull request doesn't have any backports requested or created for older release branches.

What are backports?

Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.

Semver Impact

Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.

Semantic Versioning helps users understand the impact of updates:

  • Major (X.y.z): Breaking changes that may require code modifications
  • Minor (x.Y.z): New features that maintain backward compatibility
  • Patch (x.y.Z): Bug fixes that don't change the API
  • None: Changes that don't affect using facing parts of Electron