#51558: build: only fallback to CHROMIUM_BUILDTOOLS_PATH if needed
Description of Change
Alternative to #51440. I landed an upstream change which properly finds src/buildtools for us in depot_tools, so we can drop our usage of CHROMIUM_BUILDTOOLS_PATH. The changes in this PR will do a functional test with depot_tools to determine if we have that upstream fix, and fallback to setting CHROMIUM_BUILDTOOLS_PATH if we don't.
This is safe to land on its own, but will not be a complete migration until electron/build-tools#859 lands and we bump the build-tools SHA here.
This PR also removes get_depot_tools_env from util.py as the only usage was removed in #51263.
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
Release Notes
Notes: none
Backports
No Backports Requested
This pull request doesn't have any backports requested or created for older release branches.
What are backports?
Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.
Semver Impact
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron