#51570: chore: use promise's context for memory dump callback.
Description of Change
When I was doing some crash analysis, I found that the following optimizations can be made to this code.
Remove the redundant v8::Global<v8::Context> plumbing from the process memory info callbacks.
gin_helper::Promise already retains the V8 context it was created with, so DidReceiveMemoryDump can use promise.GetContext() directly when settling the promise. This simplifies both the browser process and webContents memory info paths without changing behavior.
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - tests are changed or added
- relevant API documentation, tutorials, and examples are updated and follow the documentation style guide
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none
Backports
No Backports Requested
This pull request doesn't have any backports requested or created for older release branches.
What are backports?
Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.
Semver Impact
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron