#51586: fix: don't return a nullptr from TargetForRect
Merged
Description of Change
Resolves #51576.
The above bug was introduced by this PR: #50330.
While well-intentioned, the choice to return nullptr from a function whose contract does not explicitly allow it caused a nullptr-dereference exception inside Chromium.
RootView::UpdateCursorView* View::GetEventHandlerForPointView* View::GetEventHandlerForRectViewTargeter:TargetForRectreturnsnullptrRootView::UpdateCursorattempts to dereference thenullptr
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed a crash on MacOS when a user clicked into a title bar or top view.
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron