#51931: test: use strict mode for TS smoke tests and improve typings
Merged
Description of Change
This fell out of looking into a smoke test false negative from #50659. We had strictNullChecks off when really we should be using strict mode overall to ensure we're really testing the typings accurately and not getting false negatives.
Fixed the handling of possible null values that came out of turning on strict mode and also cleaned up some other typings while I was in there. We had some explicit type assertions that were hiding some issues like the casing of hideOthers and selectAll. Removed as many explicit any types as I could, since that defeats the point of these smoke tests.
Checklist
- I have built and tested this change
- I have filled out the PR description
Release Notes
Notes: none
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron