#52000: fix: win: check for valid taskbar handle
Merged
Description of Change
Upstreaming to e/e a fix written by @deepak1556 to address test failures that surfaced in a downstream build.
SetWindowPos() when passed a NULL value to hWndInsertAfter will position the window at HWND_TOP instead of HWND_TOPMOST that can break the assertion loop of w.isAlwaysOnTop in the specs.
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed Windows edge case in NativeWindowViews::MoveBehindTaskBarIfNeeded().
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron