#52071: build: remove unneeded stripping
Merged
- #51967 included https://chromium-review.googlesource.com/c/chromium/src/+/7932888 which broke our Linux release builds with the following error:
ERROR at //electron/build/linux/strip_binary.gni:27:3: Duplicate output file.
action("${target_name}") {
^-------------------------
Two or more targets generate the same output:
libEGL.so.stripped
This is can often be fixed by changing one of the target names, or by
setting an output_name on one of them.
Collisions:
//electron:strip_libEGL_shlib(//build/toolchain/linux:clang_x64)
//ui/gl:generate_angle_stubs_action(//build/toolchain/linux:clang_x64)
See //ui/gl/BUILD.gn:81:5: Collision.
action("generate_angle_stubs_action") {
^--------------------------------------
- This PR fixes that build error, but it does look like the offending CL is reverted upstream, so we may need to back this change out once that revert lands in #52044
Description of Change
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - tests are changed or added
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none
Backports
No Backports Requested
This pull request doesn't have any backports requested or created for older release branches.
What are backports?
Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron