#52072: test: fixup gpu info testing on linux
Merged
Description of Change
- After #51967 landed, the following test started failing on linux x64:
not ok 117 app module getGPUInfo() API succeeds with complete GPUInfo
WARN: SystemInfo_vulkan.cpp:198 (HasKhronosValidationLayer): Vulkan validation layers are missing
[3314:0618/160634.880104:ERROR:components/viz/service/main/viz_main_impl.cc:190] Exiting GPU process due to errors during initialization
Error: GPU access not allowed. Reason: GPU access is disabled due to frequent crashes.
at WebContents.<anonymous> (/__w/electron/electron/src/electron/spec/fixtures/api/gpu-info.js:9:9)
at Object.onceWrapper (node:events:631:26)
at WebContents.emit (node:events:521:24)
[3287:0618/160634.913718:ERROR:base/process/process_posix.cc:313] Unable to terminate process 3319: No such process (3)
This may have been caused by https://chromium-review.googlesource.com/c/chromium/src/+/7932888.
This PR fixes up that test to skip if the GPU process isn't available.
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - tests are changed or added
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none
Backports
No Backports Requested
This pull request doesn't have any backports requested or created for older release branches.
What are backports?
Backports are copies of changes made to the main branch that are applied to older release branches. They ensure that bug fixes and important changes are available in maintained older versions of Electron.
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron