#52367: fix: invalid printer settings when settings passed
Merged
Description of Change
- Fixes #52266
- #51814 incorrectly applied 7884451: Print Preview: Move code from PrintViewManagerBase to PrintViewManager by adding
PrintViewManagerElectron::GetPrintPreviewParamsandPrintViewManagerElectron::UpdatePrintSettingsbut these methods returned a nullptr which ended up treating every settings request as invalid.
This PR properly implements those methods and drops unneeded code from our printing patch.
Additionally, a test has been added for this regression which uses a silent virtual printer to test.
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - tests are changed or added
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: Fixed webContents.print() returning "Invalid printer settings" when print options are provided.
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron